8000 feat: scaffold a new app without a default module by lumtis · Pull Request #1214 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: scaffold a new app without a default module #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 2, 2021
Merged

feat: scaffold a new app without a default module #1214

merged 9 commits into from
Jun 2, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented May 31, 2021

The flag --no-default-module for the command app scaffold the app without a module under /x

@lumtis lumtis linked an issue May 31, 2021 that may be closed by this pull request
feat: scaffold an app without a default module #1199
Closed
@lumtis lumtis marked this pull request as ready for review May 31, 2021 11:30
@lumtis lumtis requested review from dshulyak, fadeev and ilgooz as code owners May 31, 2021 11:30
dshulyak
dshulyak previously approved these changes May 31, 2021
View reviewed changes
@fadeev
Copy link
Contributor
fadeev commented May 31, 2021

wdyt about adopting a convention --skip-SOMETHING, like --skip-module in this case?

@lumtis
Copy link
Contributor Author
lumtis commented May 31, 2021

wdyt about adopting a convention --skip-SOMETHING, like --skip-module in this case?

Mmh I actually don't know, skip to me sounds like something you "skip", you don't do during the process but the result is the same

@fadeev
Copy link
Contributor
fadeev commented May 31, 2021

Convention used by Rails, I thought this is something we can use ourselves.

Screenshot 2021-05-31 at 17 22 01

@fadeev
Copy link
Contributor
fadeev commented May 31, 2021

But yeah, I agree, let's stick to --no

fadeev
fadeev previously approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fadeev
Copy link
Contributor
fadeev commented May 31, 2021

Hold on a sec, before merging. Let's try modifying the changelog in the same PR with the code changes.

@lumtis
Copy link
Contributor Author
lumtis commented May 31, 2021

But yeah, I agree, let's stick to --no

We can still see if we want to switch to this convention in the future. There are other flags to rename as well (no-message)

My concern was if this naming would be confusing to users but if this is used for other technologies, this is fine

@ilgooz
Copy link
Member
ilgooz commented May 31, 2021

Yes, let's merge this one after releasing v0.16.1.

@lumtis lumtis dismissed stale reviews from fadeev and dshulyak via bf62110 May 31, 2021 12:44
@lumtis lumtis requested review from fadeev and dshulyak May 31, 2021 12:45
ilgooz
ilgooz reviewed May 31, 2021
View reviewed changes
integration/cmd_app_test.go Outdated

path := filepath.Join(root, appName)

_, statErr := os.Stat(filepath.Join(path, "config.yml"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to move this check to EnsureAppIsSteady?

integration/cmd_app_test.go
@@ -23,7 +24,40 @@ func TestGenerateAnAppAndVerify(t *testing.T) {
env.EnsureAppIsSteady(path)
}

func TestGenerateAnAppWithWasmAndVerify(t *testing.T) {
func TestGenerateAnAppWithNoDefaultModule(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check presence of the custom module dir at $path/x/blog, what do you think?

@lumtis lumtis requested a review from ilgooz June 1, 2021 07:02
fadeev
fadeev approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@lumtis lumtis merged commit 9ad4b4d into develop Jun 2, 2021
@lumtis lumtis deleted the feat/no-default-module branch June 2, 2021 09:52
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
feat: scaffold a new app without a default module (ignite#1214)
9a60d1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak

Assignees
5225 No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: scaffold an app without a default module
4 participants
@lumtis @fadeev @ilgooz @dshulyak
0