docs: build.go suggested edits for optional --release flag #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeev
reviewed
Jun 13, 2021
yes, I am learning! text wrap ourselves makes sense in a code file (TIL) Co-authored-by: Denis Fadeev <denis@fadeev.org>
ilgooz
reviewed
Jun 14, 2021
starport/cmd/build.go
Outdated
| --release.targets (optional). Then, binaries built for chosen targets will appear | ||
| in your app's path under release/. You can add any number of targets in GOOS:GOARCH format. | ||
| If you don't provide any, a binary will be created for your own machine. | ||
| To build binaries for a release, use the optional --release flag. The app binaries |
There was a problem hiding this comment.
to make it clear, --release flag is actually required if you want the build command work in the release mode. But --release.targets flag is optional when you use --release.
ilgooz
reviewed
Jun 14, 2021
ilgooz
reviewed
Jun 14, 2021
barriebyron
commented
Jun 14, 2021
There was a problem hiding this comment.
see how we needed clarity!? I appreciate this back and forth @ilgooz
good suggestions, wdyt now?
applying changes since it's my PR Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
ilgooz
approved these changes
Jun 15, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* suggested edits for the awesome release command * Update starport/cmd/build.go yes, I am learning! text wrap ourselves makes sense in a code file (TIL) Co-authored-by: Denis Fadeev <denis@fadeev.org> * Apply suggestions from code review applying changes since it's my PR Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Denis Fadeev <denis@fadeev.org> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edits I didn't parse during the (quick!) cycle of #1237
this --release flag is a game-changer. Starport is growing up!