8000 fix: use snake case for generated filenames by lumtis · Pull Request #1251 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use snake case for generated filenames #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2021
Merged

fix: use snake case for generated filenames #1251

merged 5 commits into from
Jun 17, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Jun 16, 2021

Quick fix to use snake case for the generated filenames since this is the convention

@lumtis lumtis requested review from fadeev and ilgooz as code owners June 16, 2021 10:30
fadeev
fadeev approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiccce 🐍

@ilgooz ilgooz merged commit 020878a into develop Jun 17, 2021
@ilgooz ilgooz deleted the feat/snakecase-filename branch June 17, 2021 07:58
@lumtis lumtis mentioned this pull request Jun 25, 2021
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix: use snake case for generated filenames (ignite#1251)
21952b0 
* Snake case

* Rename files

* Lint

* Fix proto import

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumtis @fadeev @ilgooz
0