8000 feat(docs): generate docs for cli and automate w/ by ilgooz · Pull Request #1253 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(docs): generate docs for cli and automate w/ #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Jun 16, 2021

CI.

on every push to develop, a GH action will run the generator script and
open a PR against develop branch if there is a diff.

I haven't created a seperate ToC where we list all commands as a tree because something similar already exists as a menu in the right sidebar which is produced by the web app dynamically.

Since we attach rly command from the legacy go-relayer to Starport cmd, it's also added to the docs. If you think that's too much we can avoid creating docs for it or we can remove the rly command from starport relayer.

Let me know if you want to change anything like menu name, order, description etc. for this new doc page.

CI.

on every push to develop, a GH action will run the generator script and
open a PR against develop branch if there is a diff.
@ilgooz ilgooz requested review from fadeev and lumtis as code owners June 16, 2021 13:54
@ilgooz ilgooz linked an issue Jun 16, 2021 that may be closed by this pull request
fadeev
fadeev previously approved these changes Jun 16, 2021
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 🚀

As for the relayer, tbh now that everything works with TS relayer, we might as well remove rly altogether. wdyt @lubtd ?

@lumtis
Copy link
Contributor
lumtis commented Jun 17, 2021

Love it! 🚀

As for the relayer, tbh now that everything works with TS relayer, we might as well remove rly altogether. wdyt @lubtd ?

Yes I absolutely agree with this. Go relayer is more useful for debugging but this is not an advantage if we don't make further development with the current one

8000

lumtis
lumtis previously approved these changes Jun 17, 2021
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@ilgooz ilgooz dismissed stale reviews from lumtis and fadeev via e43970a June 17, 2021 06:36
@ilgooz ilgooz merged commit c502d72 into develop Jun 17, 2021
@ilgooz ilgooz deleted the feat/auto-cli-docs branch June 17, 2021 06:36
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* feat(docs): generate docs for cli and automate w/

CI.

on every push to develop, a GH action will run the generator script and
open a PR against develop branch if there is a diff.

* docs

* Update starport/internal/tools/gen-cli-docs/main.go

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: automatically generate documentation from CLI commands
3 participants
0