8000 fix(scaffolder): remove the ibc missing placeholder error by lumtis · Pull Request #1328 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(scaffolder): remove the ibc missing placeholder error #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Jul 2, 2021

Remove the error related to the missing placeholder for ibc that prints the instructions.
We now have a generic method to detect missing placeholders and the instructions can become outdated in the future

We can also generate the module if the app.go misses placeholders

@lumtis lumtis requested review from fadeev, ilgooz and Pantani as code owners July 2, 2021 09:49
@lumtis lumtis linked an issue Jul 2, 2 8000 021 that may be closed by this pull request
@lumtis lumtis changed the title chore: remove the ibc missing placeholder error fix: remove the ibc missing placeholder error Jul 2, 2021
ilgooz
ilgooz previously approved these changes Jul 2, 2021
fadeev
fadeev previously approved these changes Jul 2, 2021
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scaffolding IBC modules in non-Starport chains, here we go! 😃

Pantani
Pantani previously approved these changes Jul 2, 2021
@lumtis lumtis dismissed stale reviews from Pantani, fadeev, and ilgooz via 2dfdab8 July 5, 2021 06:53
@lumtis lumtis requested review from fadeev, ilgooz and Pantani July 5, 2021 06:54
fadeev
fadeev previously approved these changes Jul 5, 2021
@ilgooz ilgooz changed the title fix: remove the ibc missing placeholder error fix(scaffolder): remove the ibc missing placeholder error Jul 6, 2021
@ilgooz ilgooz merged commit ddb9eec into develop Jul 6, 2021
@ilgooz ilgooz deleted the remove-git-warning branch July 6, 2021 10:45
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Scaffold an IBC module in a non-Starport chain
4 participants
0