8000 feat(nodetime/relayer): upgrade confio/relayer by ilgooz · Pull Request #1336 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(nodetime/relayer): upgrade confio/relayer #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Jul 6, 2021

@clockworkgr can you please take a look at this? Seems like it stuck at link.checkAndRelayPacketsAndAcks.

@ilgooz ilgooz changed the title Feat/upgrade tsrelayer feat(nodetime/relayer): upgrade confio/relayer Jul 6, 2021
@ilgooz ilgooz linked an issue Jul 6, 2021 that may be closed by this pull request
@ilgooz ilgooz force-pushed the feat/upgrade-tsrelayer branch from c4948f3 to bd4b088 Compare July 6, 2021 11:01
@ilgooz ilgooz changed the title feat(nodetime/relayer): upgrade confio/relayer feat(nodetime/relayer): upgrade confio/relayer Jul 6, 2021
@clockworkgr
Copy link
Collaborator

What app did you check it with? One scaffolded previously?

ts-relayer 0.2.0 is sdk >= 0.42.4 and rpc >=0.34.9 only as it uses the /block_search endpoint

@clockworkgr
Copy link
Collaborator

Relevant discussion: confio/ts-relayer#188

@ilgooz
Copy link
Member Author
ilgooz commented Jul 6, 2021

I tested with starport relayer cmd.

@clockworkgr
Copy link
Collaborator

I tested with starport relayer cmd.

on what chains?

@ilgooz
Copy link
Member Author
ilgooz commented Jul 6, 2021

Nothing spesific, I tested with various chains including local ones. Does it work for you on any spesific chain?

@clockworkgr
Copy link
Collaborator

ah...seems like there are 2 issues

a) 0.2.0 won't work with chains that use SDK < 0.42.4 and tendermint <0.34.9
b) a separate issue i'm bugging ethan about :P

@clockworkgr
Copy link
Collaborator

Actually scratch that...it works for me between 2 chains using the correct versions (just scaffolded using starport)

The error I'm bugging ethan about has to do with Acks sometimes showing up twice. But it doesnt stop the relayer from working.

@ilgooz
Copy link
Member Author
ilgooz commented Jul 7, 2021

Oh okay, then should we make starport relayer command quit with a warning if any of these nodes does not comply with the min. required versions of sdk and tendermint? cc @fadeev

@fadeev
Copy link
Contributor
fadeev commented Jul 7, 2021

@ilgooz I don't think it's possible to determine the version of the SDK used by the node. If there are any indicator we can use, I still think we should just print a warning, but not quit the relayer.

@ilgooz
Copy link
Member Author
ilgooz commented Jul 12, 2021

/node_info expoind from api. provides dependency list and their version but not available in the rpc.. We may be able to call the node info with some trick but seems like not a priority.

@ilgooz ilgooz changed the base branch from develop to feat/bandchain-oracle-support July 12, 2021 07:59
@ilgooz ilgooz marked this pull request as ready for review July 12, 2021 07:59
@ilgooz ilgooz requested review from fadeev, lumtis and Pantani as code owners July 12, 2021 07:59
@ilgooz ilgooz merged commit e8cdb83 into feat/bandchain-oracle-support Jul 12, 2021
@ilgooz ilgooz deleted the feat/upgrade-tsrelayer branch July 12, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ts-relayer
3 participants
0