-
Notifications
You must be signed in to change notification settings - Fork 564
feat(nodetime/relayer): upgrade confio/relayer #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c4948f3
to
bd4b088
Compare
What app did you check it with? One scaffolded previously? ts-relayer 0.2.0 is sdk >= 0.42.4 and rpc >=0.34.9 only as it uses the /block_search endpoint |
Relevant discussion: confio/ts-relayer#188 |
I tested with |
on what chains? |
Nothing spesific, I tested with various chains including local ones. Does it work for you on any spesific chain? |
ah...seems like there are 2 issues a) 0.2.0 won't work with chains that use SDK < 0.42.4 and tendermint <0.34.9 |
Actually scratch that...it works for me between 2 chains using the correct versions (just scaffolded using starport) The error I'm bugging ethan about has to do with Acks sometimes showing up twice. But it doesnt stop the relayer from working. |
Oh okay, then should we make |
@ilgooz I don't think it's possible to determine the version of the SDK used by the node. If there are any indicator we can use, I still think we should just print a warning, but not quit the relayer. |
|
@clockworkgr can you please take a look at this? Seems like it stuck at
link.checkAndRelayPacketsAndAcks
.