8000 fix(cmd/generate): vuex and openapi cmds should work by ilgooz · Pull Request #1356 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(cmd/generate): vuex and openapi cmds should work #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2021
Merged

fix(cmd/generate): vuex and openapi cmds should work #1356

merged 5 commits into from
Jul 13, 2021

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Jul 12, 2021

whether if 'client' section presents or not in the 'config.yml'.

@ilgooz
fix(cmd/generate): vuex and openapi cmds should work
be849d2 
whether if 'client' section presents or not in the 'config.yml'.
@ilgooz ilgooz requested review from fadeev, lumtis and Pantani as code owners July 12, 2021 08:58
This was linked to issues Jul 12, 2021
TS generation and build fails if vue dir is deleted #1350
Closed
starport g vuex doesn't generate code #1351
Closed
fadeev
fadeev suggested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One suggestion is let's make starport g vuex behave like starport g vuex --rebuild-proto-once, so every time it generates proto for everything. We can drop the flag.

@ilgooz
Copy link
Member Author
ilgooz commented Jul 12, 2021 •
edited
Loading

Any spesific reason to this? Because build and serve command takes the same approach. By removing this flag, one drawback I can think of is, it'll take too much time to complate this command. User also may not care about generating vuex code except their own modules.

@fadeev
Copy link
Contributor
fadeev commented Jul 12, 2021

Consensus is that we generate everything by default with starport g vuex, remove --rebuild-proto-once.

@ilgooz
Copy link
Member Author
ilgooz commented Jul 12, 2021

Handled by 623bab4. 👍

@ilgooz ilgooz requested a review from fadeev July 12, 2021 14:14
@ilgooz ilgooz merged commit 7342975 into develop Jul 13, 2021
@ilgooz ilgooz deleted the fix/codegen-client branch July 13, 2021 06:01
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
fix(cmd/generate): vuex and openapi cmds should work (ignite#1356)
1c243e8 
* fix(cmd/generate): vuex and openapi cmds should work

whether if 'client' section presents or not in the 'config.yml'.

* fix generate all logic for build and serve

* fix

* generate all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@Pantani Pantani Pantani approved these changes

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

starport g vuex doesn't generate code TS generation and build fails if vue dir is deleted
3 participants
@ilgooz @fadeev @Pantani
0