feat(pkg/chaincmd/runner): support YAML encoded CLI response #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
commented
Aug 16, 2021
Pantani
reviewed
Aug 16, 2021
| } | ||
|
|
||
| type buffer struct { | ||
| *bytes.Buffer |
There was a problem hiding this comment.
Suggested change
| *bytes.Buffer | |
| b *bytes.Buffer |
A good suggestion from the Uber code style
There was a problem hiding this comment.
uber looks like very opinionated on this. although it does not apply to our case. they recommend avoiding it for public struct in our case, buffer is a private one.
|
The faucet seems to be working for me, but for some reason I'm seeing mnemonics 😬 Works fine on |
ilgooz
added a commit
that referenced
this pull request
Aug 17, 2021
* feat(templates/cmd): upgrade spm to add 'config' cmd (#1417) * feat(templates/cmd): upgrade spm to add 'config' cmd to appd. * also make $HOME/config/client.toml configurable through 'init.client' section of chain's Starport config.yml. * default to test * fix * fix * updated changelog * fix config application order * fix Co-authored-by: Denis Fadeev <denis@fadeev.org> * fix(services/chain): detecting keyring (#1449) * fix(services/chain): detecting keyring when client.toml > keyring-backend used. * fix * fix * default to test kb * fix * fix(services/chain): default home dir for app (#1457) * fix(services/chain): support 0.43.x based chains (#1455) * Apply suggestions from code review * Apply suggestions from code review * feat(pkg/chaincmd/runner): support YAML encoded CLI response (#1468) * feat(pkg/chaincmd/runner): support YAML encoded CLI response * Apply suggestions from code review * fix * fix * fix * fix Co-authored-by: Denis Fadeev <denis@fadeev.org>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat(templates/cmd): upgrade spm to add 'config' cmd (ignite#1417) * feat(templates/cmd): upgrade spm to add 'config' cmd to appd. * also make $HOME/config/client.toml configurable through 'init.client' section of chain's Starport config.yml. * default to test * fix * fix * updated changelog * fix config application order * fix Co-authored-by: Denis Fadeev <denis@fadeev.org> * fix(service 7A53 s/chain): detecting keyring (ignite#1449) * fix(services/chain): detecting keyring when client.toml > keyring-backend used. * fix * fix * default to test kb * fix * fix(services/chain): default home dir for app (ignite#1457) * fix(services/chain): support 0.43.x based chains (ignite#1455) * Apply suggestions from code review * Apply suggestions from code review * feat(pkg/chaincmd/runner): support YAML encoded CLI response (ignite#1468) * feat(pkg/chaincmd/runner): support YAML encoded CLI response * Apply suggestions from code review * fix * fix * fix * fix Co-authored-by: Denis Fadeev <denis@fadeev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.