8000 feat(docs): add `simapp` doc by Pantani · Pull Request #1851 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(docs): add simapp doc #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 17, 2021
Merged

feat(docs): add simapp doc #1851

merged 11 commits into from
Dec 17, 2021

Conversation

Pantani
Copy link
Collaborator
@Pantani Pantani commented Nov 30, 2021 •
edited
Loading

Description

  • Add doc for starport simapp scaffolding;
  • Fix the simulation command for a scaffolded chain;

TODO

@Pantani Pantani self-assigned this Nov 30, 2021
@Pantani Pantani requested a review from barriebyron November 30, 2021 05:06
fadeev
fadeev previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Pantani Pantani requested a review from fadeev November 30, 2021 12:42
lumtis
lumtis reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor
@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Maybe we can also introduce the concept of invariant, some checks that determine the Blockchain state is inconsistent and the chain must be stopped. And simulation testing can be used to detect broken invariant.

Depends how much information we want to give, we can also redirect to the SDK docs: https://docs.cosmos.network/master/building-modules/simulator.html

barriebyron
barriebyron previously approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor
@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with the changes, I expect this doc to evolve and keep getting better, it's going to be a hit!

@Pantani Pantani marked this pull request as draft December 2, 2021 19:16
@Pantani Pantani added this to the v0.19 milestone Dec 13, 2021
@Pantani Pantani marked this pull request as ready for review December 17, 2021 02:44
@Pantani
Copy link
Collaborator Author
Pantani commented Dec 17, 2021

@barriebyron, I made some changes by adding more info. Can you help and review again, please?

@ilgooz
Copy link
Member
ilgooz commented Dec 17, 2021 •
edited
Loading

@barriebyron merging this now for the next release, please feel free to put more reviews here so, we can add them through another PR.

@ilgooz ilgooz merged commit c37a382 into develop Dec 17, 2021
@ilgooz ilgooz deleted the feat/simulation-doc branch December 17, 2021 09:20
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Pantani @ilgooz @barriebyron
feat(docs): add simapp doc (ignite#1851)
79a945b 
* add simapp doc

* add cosmos simapp doc link

* edits for awesome new sim app file

* improve simulation description

* add chain invariants tutorial

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Co-authored-by: Barrie Byron <barriebyron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz Awaiting requested review from ilgooz

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

@fadeev fadeev Awaiting requested review from fadeev

@barriebyron barriebyron Awaiting requested review from barriebyron

@lumtis lumtis Awaiting requested review from lumtis

Assignees

@Pantani Pantani

Labels
None yet
Projects
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
5 participants
@Pantani @ilgooz @fadeev @lumtis @barriebyron
0