feat(docs): add starport types doc #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
reviewed
Nov 30, 2021
barriebyron
previously approved these changes
Dec 1, 2021
There was a problem hiding this comment.
approved with the requested changes, I anticipate that this reference doc will be a big hit, thank you @Pantani
barriebyron
approved these changes
Dec 1, 2021
barriebyron
reviewed
Dec 1, 2021
| | coin | - | no | sdk.Coin | Cosmos SDK coin type | | ||
| | array.coin | coins | no | sdk.Coins | List of Cosmos SDK coin types | | ||
|
|
||
| You cannot use some types as an index, like the map and list indexes and module params. |
There was a problem hiding this comment.
Suggested change
| You cannot use some types as an index, like the map and list indexes and module params. | |
| **Note:** Map, list indexes, and module params cannot be used as an index. |
There was a problem hiding this comment.
@Pantani let's be clear on which types can be used as an index (the command descriptions maybe?) or is this good?
There was a problem hiding this comment.
I added it to the table. There is a section called Index
barriebyron
approved these changes
Dec 1, 2021
| | coin | - | no | sdk.Coin | Cosmos SDK coin type | | ||
| | array.coin | coins | no | sdk.Coins | List of Cosmos SDK coin types | | ||
|
|
||
| You cannot use some types as an index, like the map and list indexes and module params. |
There was a problem hiding this comment.
@Pantani let's be clear on which types can be used as an index (the command descriptions maybe?) or is this good?
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* add starport types doc * improve docs commands * fix binary name * edits to new awesome types reference doc * change order * types * add info about supported index types Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Barrie Byron <barriebyron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a doc to show all starport supported types.