docs: update the frontend section #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadeev
suggested changes
Dec 8, 2021
docs/kb/serve.md
Outdated
| @@ -62,7 +62,7 @@ Reset the state only once. Use this flag to resume a failed reset or to initiali | |||
|
|
|||
| Reset state on every file change. Do not import state and turn off state persistence. | |||
|
|
|||
| `--rebuild-proto-once` use with `--reset-once` | |||
| `starport generate vuex` | |||
There was a problem hiding this comment.
Suggested change
| `starport generate vuex` |
I think we should just remove this from the serve command doc. It's a separate command now.
docs/kb/serve.md
Outdated
| @@ -62,7 +62,7 @@ Reset the state only once. Use this flag to resume a failed reset or to initiali | |||
|
|
|||
| Reset state on every file change. Do not import state and turn off state persistence. | |||
|
|
|||
| `--rebuild-proto-once` use with `--reset-once` | |||
| `starport generate vuex` | |||
|
|
|||
| Force code generation from proto files for custom and third-party modules. By default, Starport statically scaffolds files generated from Cosmos SDK standard proto files, instead of generating them dynamically. Use this flag to perform code generation on all modules if a blockchain was scaffolded on an earlier Starport version or after a Cosmos SDK upgrade. | |||
There was a problem hiding this comment.
Suggested change
| Force code generation from proto files for custom and third-party modules. By default, Starport statically scaffolds files generated from Cosmos SDK standard proto files, instead of generating them dynamically. Use this flag to perform code generation on all modules if a blockchain was scaffolded on an earlier Starport version or after a Cosmos SDK upgrade. |
This paragraph only makes sense in the context of the flags above.
docs/kb/frontend.md
Outdated
|
|
||
| `starport chain serve --reset-once --rebuild-proto-once` | ||
| `starport chain serve --reset-once` |
There was a problem hiding this comment.
Suggested change
| `starport chain serve --reset-once` |
You technically don't need to serve a chain to generate Vuex client.
|
Thanks for contributing, @championshuttler! ✨ |
729aa04 to
74dcca4
Compare
fadeev
approved these changes
Dec 9, 2021
barriebyron
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
thanks for picking this up @championshuttler we appreciate your contributions!
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829