8000 type command: supports dashes in app names by ilgooz · Pull Request #210 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

type command: supports dashes in app names #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2020
Merged

type command: supports dashes in app names #210

merged 5 commits into from
Aug 31, 2020

Conversation

ilgooz
Copy link
Member
@ilgooz ilgooz commented Aug 31, 2020 •
edited
Loading

#208

@fadeev can you please double check the all commands again (looks fine in my tests), I made a core change in this PR.

  • Updated changelog.

@ilgooz ilgooz requested a review from fadeev as a code owner August 31, 2020 12:25
fadeev
fadeev previously approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine! Props on fixing this so quickly ⚡️

One thing I've noticed, it can be handled in a different PR:

fadeev@system hello-world % hello-worldcli tx
Transactions subcommands

Usage:
  helloworldcli tx [command]

Available Commands:
  send        Create and sign a send tx

The actual binary matches the project name (with a dash), but in the CLI help the command shows up without a dash.

@fadeev
Copy link
Contributor
fadeev commented Aug 31, 2020

Oh, one more thing.

fadeev@system tendermint % starport serve --path hello-world

📦 Installing dependencies...
🛠️  Building the app...
cannot build app:

        stat /Users/fadeev/tendermint/cmd/hello-worldd: directory not found

waiting for a fix before retrying...

@ilgooz
Copy link
Member Author
ilgooz commented Aug 31, 2020 •
edited
Loading

Both fixed by 0a0d208 and 24f3b0d! 💯

@ilgooz ilgooz requested a review from fadeev August 31, 2020 14:35
@ilgooz ilgooz linked an issue Aug 31, 2020 that may be closed by this pull request
type: Error in chain with hyphen in name #208
Closed
@ilgooz ilgooz removed a link to an issue Aug 31, 2020
type: Error in chain with hyphen in name #208
Closed
@ilgooz ilgooz linked an issue Aug 31, 2020 that may be closed by this pull request
Release v0.10.0 #209
Closed
5 tasks
@ilgooz
Copy link
Member Author
ilgooz commented Aug 31, 2020

I think there is a problem with GH CI atm, workflows haven't started running.

fadeev
fadeev approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor
@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ilgooz ilgooz merged commit 662619b into develop Aug 31, 2020
@ilgooz ilgooz deleted the fix/type-dash branch August 31, 2020 15:18
@ilgooz ilgooz mentioned this pull request Aug 31, 2020
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
type command: supports dashes in app names (ignite#210)
e7c2eee 
* type command: supports dashes in app names

* update changelog

* services/serve: fix determining root path of the app

* services/serve: fix binary name in the appd and appcli

* trig ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v0.10.0
2 participants
@ilgooz @fadeev
0