test(service/network): introduce unit testing tooling #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a468abd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1aa67719.ignite-docs.pages.dev |
|
Hey @ivanovpetr, what's the status on this, is it ready for reviews? (we merged cosmosaccount change recently. |
ilgooz
requested changes
Apr 11, 2022
|
Let's also resolve the conflicts. 👍 |
added 2 commits
April 14, 2022 19:10
Conflicts: ignite/cmd/network.go ignite/pkg/cosmosclient/cosmosclient.go ignite/services/network/campaign.go ignite/services/network/join.go ignite/services/network/join_test.go ignite/services/network/launch.go ignite/services/network/launch_test.go ignite/services/network/mocks/account_info.go ignite/services/network/mocks/campaign_client.go ignite/services/network/mocks/chain.go ignite/services/network/mocks/cosmos_client.go ignite/services/network/mocks/launch_client.go ignite/services/network/mocks/profile_client.go ignite/services/network/mocks/reward_client.go ignite/services/network/network.go ignite/services/network/publish.go ignite/services/network/publish_test.go ignite/services/network/queries.go ignite/services/network/request.go ignite/services/network/testutil/account.go ignite/services/network/testutil/chain.go ignite/services/network/testutil/genesis.go ignite/services/network/testutil/gentx.go ignite/services/network/testutil/mocks.go ignite/services/network/testutil/response.go ignite/services/network/testutil/suite.go
|
Enhancements to do in this PR
|
ilgooz
reviewed
Apr 15, 2022
|
Looks very good! |
ilgooz
requested changes
Apr 18, 2022
This was referenced Apr 19, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* implement unit testing tooling for the network package * implement unit testing tooling for the network package * tests for Publish function * tests for Join function * refactor test accounts * revert accidental testada rename * refactor tests * rename starport to ignite * add tests fo SetReward * add tests fo RevertLaunch * add review fixes * add review fixes * simplify Network constructor Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces test utils for testing network package. The main novations are.
As an example of application of these tools I introduce tests for launch function of network package. Would like to hear as much feedback as possible prior writing other tests.