feat(network/publish): add support for source URLs without protocol #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilgooz
approved these changes
Apr 19, 2022
|
@jeronimoalbi congrats on the first merge! |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…gnite#2389) * feat(pkg/xurl): add function to ensure HTTPS scheme * chore(network/publish): change command to ensure the https scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2380
The changes in the PR ensure that the source URL argument in the
ignite network chain publishcommand is always prefixed with the "https://" prefix.