refactor(pkg/xurl): change protocol functions to prevent possible bugs #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "TestHTTPEnsurePort" was slightly changed to be consistent with the existing table driven tests conventions.
cee5ef0 to
0f468e2
Compare
ivanovpetr
previously approved these changes
Apr 21, 2022
ivanovpetr
previously approved these changes
Apr 22, 2022
The protocol related functions now check for values like for example 0.0.0.0:42 or localhost:42 that can't be parsed by the net package because the scheme is not defined.
ilgooz
approved these changes
Apr 28, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
ignite#2392) * refactor(pkg/xurl): add error support to protocol functions * refactor(pkg/xurl): change existing ensure port test for consistency The "TestHTTPEnsurePort" was slightly changed to be consistent with the existing table driven tests conventions. * refactor: change calls to xurl protocol functions to handle errors * refactor(pkg/xurl): add constants for scheme types * fix: formatting * fix: formatting * fix(pkg/xurl): change ensure protocol function to handle ADDR:HOST The protocol related functions now check for values like for example 0.0.0.0:42 or localhost:42 that can't be parsed by the net package because the scheme is not defined. * chore: review improvements * feat(pkg/xurl): add MightHTTPS function * chore: change network publish command to ensure http/https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2390
Description
The protocol related functions should be refactored to avoid errors: