8000 feat(cmd/scaffold): confirm when scaffolding over not staged changes by Grinion · Pull Request #2409 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cmd/scaffold): confirm when scaffolding over not staged changes #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat(cmd/scaffold): confirm when scaffolding over not staged changes #2409

merged 2 commits into from
Apr 28, 2022

Conversation

Grinion
Copy link
Contributor
@Grinion Grinion commented Apr 25, 2022

Issue: #2394

@Grinion
Add confirmation when scaffolding over not staged changes
1b066de 
Bounty address: cosmos1r9vfrfqypw4zkhkw0pja36tr9yrfqujcf9u3sw
@ilgooz ilgooz changed the title feat(scaffold): Add confirmation when scaffolding over not staged changes feat(cmd/scaffold): conform when scaffolding over not staged changes Apr 25, 2022
@ilgooz ilgooz changed the title feat(cmd/scaffold): conform when scaffolding over not staged changes feat(cmd/scaffold): confirm when scaffolding over not staged changes Apr 25, 2022
@ilgooz ilgooz linked an issue Apr 25, 2022 that may be closed by this pull request
ask confirmation when scaffolding over not staged changes #2394
Closed
@ilgooz ilgooz added the bounty label Apr 25, 2022
ivanovpetr
ivanovpetr reviewed Apr 26, 2022
View reviewed changes
ilgooz
ilgooz requested changes Apr 26, 2022
View reviewed changes
Copy link
Member
@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 I left some comments.

@Grinion Grinion requested review from ilgooz and ivanovpetr April 28, 2022 11:17
@ilgooz ilgooz merged commit 4784cf8 into ignite:develop Apr 28, 2022
@Grinion Grinion deleted the issue-2394-ask-confirmation-when-not-staged-changes branch April 28, 2022 15:47
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Grinion
feat(cmd/scaffold): confirm when scaffolding over not staged changes (i…
0ce3040 
…gnite#2409)

* Add confirmation when scaffolding over not staged changes

Bounty address: cosmos1r9vfrfqypw4zkhkw0pja36tr9yrfqujcf9u3sw

* Resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis

@Pantani Pantani Awaiting requested review from Pantani

@ilgooz ilgooz Awaiting requested review from ilgooz

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

Assignees
No one assigned
Labels
bounty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ask confirmation when scaffolding over not staged changes
3 participants
@Grinion @ilgooz @ivanovpetr
0