8000 fix(network): fix validator pubkey parser from gentx by Pantani · Pull Request #2456 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(network): fix validator pubkey parser from gentx #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2022
Merged

fix(network): fix validator pubkey parser from gentx #2456

merged 4 commits into from
May 10, 2022

Conversation

Pantani
Copy link
Collaborator
@Pantani Pantani commented May 10, 2022

Description

We are parsing the pubkey wrong as a simple byte array, we should decode to base64 and wrapper into an ed25519 pubkey

@Pantani Pantani self-assigned this May 10, 2022
ilgooz
ilgooz requested changes May 10, 2022
View reviewed changes
Copy link
Member
@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the other tests as well?

@Pantani Pantani requested a review from ilgooz May 10, 2022 19:47
@ilgooz ilgooz merged commit 2e53838 into develop May 10, 2022
@ilgooz ilgooz deleted the fix/validator-pub-key branch May 10, 2022 20:15
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Pantani
fix(network): fix validator pubkey parser from gentx (ignite#2456)
287e513 
* fix validator pubkey parser from gentx

* fix unit tests

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@ilgooz ilgooz Awaiting requested review from ilgooz

Assignees

@Pantani Pantani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @ilgooz
0