ci: fix integration tests errors with text file busy
#2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script has a fixed name to comply with `protoc` plugin naming requirements but it it always generated in the same temporary folder which means that concurrent calls would overwrite the `protoc-gen-ts_proto` file. This changeset generates the script in random temporary folders. This fix might help correcting "flaky" integration tests.
8000
text file busytext file busy
tbruyelle
previously approved these changes
Jul 28, 2022
|
👏 |
|
Is it still a draft @jeronimoalbi ? |
Yes, I don't think the current change really fixes the issue. |
This allow calling Generate multiple times using a single protoc binary. Otherwise a protoc binary would be created each time Generate is called.
New changes were added to use a single |
aljo242
previously approved these changes
Aug 3, 2022
ilgooz
reviewed
Aug 3, 2022
lumtis
approved these changes
Aug 4, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* fix: change `protoc-gen-ts_proto` to generate in random folders The script has a fixed name to comply with `protoc` plugin naming requirements but it it always generated in the same temporary folder which means that concurrent calls would overwrite the `protoc-gen-ts_proto` file. This changeset generates the script in random temporary folders. This fix might help correcting "flaky" integration tests. * refactor(pkg/protoc): add WithCommand option to Generate This allow calling Generate multiple times using a single protoc binary. Otherwise a protoc binary would be created each time Generate is called. * refactor(pkg/cosmosgen): change JS generator to reuse protoc binary * chore: simplify code Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2657