feat: make go dependency validation during build optional #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allow to make the call to `go mod verify` optional and disabled by default to avoid issues with module ziphash files when a Go workspace is being used.
|
Hey @robert-zaremba, this PR may fix the issue that you were experiencing in #137. |
|
Thanks! |
Closed
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat: add chain option to enable dependencies verification This option allow to make the call to `go mod verify` optional and disabled by default to avoid issues with module ziphash files when a Go workspace is being used. * feat: add check dependencies flag to chain init, build and serve * feat: add check dependencies flag to network chain commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #137
These changes makes
go mod verifyduring build optional. The default behaviour is not to verify during build.App dependencies verification is a good practice but is not really required for the build.
By default, these changes bypass the verification to avoid the missing ziphash files for local modules that can happen when a workspace is used. The real issue seems to be a Go tooling issue that happens when
go mod verifyis run within a Go workspace context.