8000 fix(network): fix default chain ID for publish by lumtis · Pull Request #2717 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(network): fix default chain ID for publish #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix(network): fix default chain ID for publish #2717

merged 1 commit into from
Aug 9, 2022

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Aug 9, 2022

Set the default chain ID as <name>-1 whatever if a chain ID is defined or not in config.yml

@lumtis lumtis linked an issue Aug 9, 2022 tha 8000 t may be closed by this pull request
publish: failure if the chain has a custom chain-id in config.yml #2706
Closed
@lumtis lumtis self-assigned this Aug 9, 2022
@ilgooz ilgooz merged commit c68c956 into develop Aug 9, 2022
@ilgooz ilgooz deleted the fix/network-custom-chain-id branch August 9, 2022 08:54
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
fix(network): fix default chain ID for publish (ignite#2717)
e5bd64f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@aljo242 aljo242 Awaiting requested review from aljo242

@tbruyelle tbruyelle Awaiting requested review from tbruyelle

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publish: failure if the chain has a custom chain-id in config.yml
2 participants
@lumtis @ilgooz
0