8000 refactor(`network`): upgrade `spn` by lumtis · Pull Request #2816 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(network): upgrade spn #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 12, 2022
Merged

refactor(network): upgrade spn #2816

merged 21 commits into from
Sep 12, 2022

Conversation

lumtis
Copy link
Contributor
@lumtis lumtis commented Sep 7, 2022 •
edited
Loading

Part of #2812

  • Includes last changes where remaining-time is replaced by absolute launch-time
  • Replace request specific message by MsgSendRequest
  • Add --account-balance flag in publish for the coordinator to fix genesis account balance
  • Automatically use account balance in join if it exists

Testing

SPN:

ignite c serve -r --skip-proto -c config_2.yml

Ignite

ignite n chain publish https://github.com/lubtd/planet --local

ignite n chain init 1 --local

ignite n chain join 1 --amount 100000000stake --local

ignite network chain launch 1 --local --launch-time "2020-01-01T12:00:00Z"
launch time 2020-01-01 12:00:00 +0000 UTC lower than minimum 2022-09-07 14:35:12.729707 +0200 CEST m=+35.074284068

ignite network chain launch 1 --local --launch-time "2024-01-01T12:00:00Z"
launch time 2024-01-01 12:00:00 +0000 UTC bigger than maximum 2022-09-14 14:34:55.555845 +0200 CEST m=+604800.066851169

ignite network chain launch 1 --local --launch-time "2022-09-08T12:00:00Z"
✔ Chain 1 will be launched on 2022-09-08 12:00:00 +0000 UTC

@lumtis lumtis self-assigned this Sep 7, 2022
@lumtis lumtis marked this pull request as draft September 7, 2022 12:59
@lumtis lumtis marked this pull request as ready for review September 7, 2022 13:35
aljo242
aljo242 previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor
@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aljo242
Copy link
Contributor
aljo242 commented Sep 7, 2022

Changelog?

@lumtis
Copy link
Contributor Author
lumtis commented Sep 7, 2022

Changelog?

I will continue to work on this PR for some of the other changes so it can remain open for review without me being blocked.
The changelog will simply be upgrade spn

Btw I don't think we need to enforce changelog for each PR, sometimes it's not relevant and the changelog file shouldn't be too much extensive

@lumtis lumtis changed the title refactor(network): upgrade spn and replace remaining-time by launch-time refactor(network): upgrade spn Sep 8, 2022
tbruyelle
tbruyelle previously approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor
@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lumtis lumtis requested review from aljo242 and tbruyelle September 8, 2022 12:20
tbruyelle
tbruyelle previously approved these changes Sep 12, 2022
View reviewed changes
@lumtis @tbruyelle
Update ignite/cmd/network_chain_join.go
996b3ba 
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
@lumtis lumtis merged commit 83ab4c8 into develop Sep 12, 2022
@lumtis lumtis deleted the network/launch-time branch September 12, 2022 13:41
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis @tbruyelle
refactor(network): upgrade spn (ignite#2816)
af3f443 
* update go mod

* clock package

* refactor network

* new cmd

* last changes

* typoe

* import

* fix unit test

* fix test 2

* Upgrade for send request

* publish: add balance

* new logic for adding accounts

* format

* change switch

* changelog

* Update ignite/cmd/network_chain_join.go

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@fadeev fadeev Awaiting requested review from fadeev

@aljo242 aljo242 Awaiting requested review from aljo242

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumtis @aljo242 @tbruyelle
0