Fix CPU is consumed by OSC while hidden, #3601 #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
The fix in PR iina#3434 MUST be merged before merging this commit.. This commit will: - Change MainWindowController.hideUI to stop the timer that updates the OSC - Change MainWindowController.showUI to sync the UI and start the timer - Change PlaybackInfo.constrainVideoPosition to check that`videoPosition is not nil
|
Hold off reviewing this one. Causes a hang in mpv. Testing a fix for the fix. |
|
The hang was traced to mpv and handling of FLAC files. This "fix" is faulty and can trigger a main thread hang in |
|
The concern over this change was due to a user reporting a hang immediately after this fix was merged into a fork of IINA. Eventually that hang was traced to a mpv problem with FLAC encoded files. Reopening. |
|
Thanks for the PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in PR #3434 MUST be merged before merging this commit..
This commit will:
Change MainWindowController.hideUI to stop the timer that updates
the OSC
Change MainWindowController.showUI to sync the UI and start the timer
Change PlaybackInfo.constrainVideoPosition to check that`videoPosition
is not nil
This change has been discussed with the author.
It implements / fixes issue CPU is consumed by OSC while hidden #3601.
Description:
See issue for details. Don't miss the above note about merging PR #3434 first!