Fix IINA is not associated with GIF files, #3679 #3680
Conversation
|
I think the graphical elements should be consistent. If updating one document icon, we should remake all of them. I suggest we postpone this change until the next release. We may also want to add some other enhancements for gif files. |
|
On postponing GIF support to consider if other enhancements are needed, sounds good. Let's hold off merging this. On the document icon issue, a full set of updated document icons are ready. I did not post a PR as it didn't seem appropriate for a bug fix release focused on critical issues. The commit is low-batt@43aeac1. See discussion 3670 for details. I think he is right about the current document icons needing to be updated to follow the new HIG requirements. With the current release plan I'm thinking we should consider including the updated icons as "polish" Have a look at that discussion and see what you think. |
|
Hey do you have any idea why the doc icons doesn't copy to iina app when building it ? |
|
Thanks for entering the issue about that. Unrelated to this PR, a PR was merged that was supposed to update the doc icons. Looks like something went wrong with that. I'm in the middle of another PR at the moment, but will look into the icon problem soon. |
The commit in the pull request will: - Add a document type entry for GIF files to Info.plist - Add document icons for GIF files as Assets
The commit in the pull request will: - Add an imported type entry for GIF files to Info.plist - Add a document type entry for GIF files to Info.plist - Add document icons for GIF files as Assets Thank you @Zabriskije for creating the document icon. Co-authored-by: Zabriskije <zabriskije@gmail.com>
|
Added importing the GIF type entry and rebased with The document icons have been updated, so the new document icon included in this PR now is consistent with the other document icons. The other issue that was raised is the possibility of adding other enhancements for gif files. Not sure what that would be. I played around with animated GIFs from tenor. The IINA video controls I tried all worked. |
The commit in the pull request will:
Add a document type entry for GIF files to Info.plist
Add document icons for GIF files as Assets
This change has been discussed with the author.
It implements / fixes issue IINA is not associated with GIF files #3679.
Description:
The changes in the commit associate IINA with GIF files. The document icons are in the latest style required by the Apple HIG. Thank you to @Zabriskije for supplying the icons.