Added controls to QuickSettingsPanel to control second subtitles position and delay #5020
Conversation
There was a problem hiding this comment.
I really like the segmented controls. They look great and should be easy for users to understand.
I pushed a commit to add the segmented control label names to QuickSettingViewController.strings. With that I think this can be merged as is. The next step is to add the corresponding OSD messages for secondary sub position and delay changing like we have for the primary sub.
Need to merge the simple PR #5019 that adds a couple of missing secondary options to watch-later-options.
"Secondary" is the proper term. We should consider changing the menu items that use the term "Second".
And of course subtitle preferences needs some enhancement in this area.
To test this I used the YouTube video 10 Minute Timer (count-up stopwatch) with these two subtitle files:
sub-1.srt.txt
sub-2.srt.txt
I checked RTL:
The messed up label at the end of the delay slider is issue #4895 / PR #4896. That PR is in draft mode because it needs a UI expert to take over from me and solve the last little issue shown in the screenshots in this comment.
|
One more related topic. The secondary-sub-pos, like sub-pos has a range of 0% to 150%. IINA tries to limit it to 100%. I believe this is because unlike mpv IINA ties the window size to the video size. I know removing that restriction has been reported in multiple issues, for example #4712. @svobs has looked into this. Anyway, I said "tries" because if you keep pressing the |
Sorry I forgot to do that, and thanks!
I was unsure of how to design the UI to add secondary subtitles in, so I didn't include that in this PR.
Besides this, I remember I've heard that the word "subtitle" should always be in plural form, is that correct? Should we enforce that (in the future)? |
|
It usually is "subtitles" but not always "subtitles". It is a "subtitle file" as can be seen in the mpv manual entry for the sub-file option:
It is a "subtitle stream" as can be seen in the mpv manual entry for the sid option:
The IINA menu items are about selecting a "subtitle stream". One label that should be changed is the |
|
Update the styling and also enabled the macOS 13+ NSColorWell. |
|
Is this in the latest release? Been waiting for this fix for a while now! ❤️ |
|
IINA has been finally working on the long delayed "feature release". This is one of the changes going into that release. This pull request is in the As this next release contains lots of changes considered risky it will use beta releases. We are at this moment working on winding down the changes in preparation of cutting a release. We still have a handful of pull requests to review and merge. Then we will do some more testing before starting on the release process. There have been many requests for better controls for secondary subtitles. IINA had to wait for the mpv project to add additional options for controlling the secondary subtitles. They finally did, allowing IINA to add new UI to access the new abilities. |
|
Great to know. Thanks @low-batt ! |
|
If you ever encounter a crash running a Nightly build, please report it. Changes are tested and reviewed before being merged into the Nightly build, so there should not be any new crashes. However, it is possible for a mistake to make it through the process. So if you find any sort of regression, a crash, a malfunction, a performance problem, we'd like to know. |
Description:
mpv recently added
secondary-sub-posandsecondary-sub-delayoptions, which enables user to control position and delay separately for primary subtitles and secondary subtitles. This PR implement these two new options by added a SegmentedControl in the QuickSettingsPanel to let user choose from primary or secondary subtitles when adjusting subtitle position and delay.Note that the other options (e.g.
sub-scale) apply to both primary subtitles and secondary subtitles, so they are outside of the NSBox.Screen.Recording.2024-06-24.at.12.36.33.mov
The layout of the subtitle tab of the QuickSettingPanel also got changed to better illustrate the new feature (before -> after):