8000 Fix the window is shifted when pinching to resize by uiryuu · Pull Request #5021 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the window is shifted when pinching to resize #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix the window is shifted when pinching to resize #5021

merged 1 commit into from
Jul 1, 2024

Conversation

uiryuu
Copy link
Member
@uiryuu uiryuu commented Jun 24, 2024

Description:
This commit:

  • Caches the window frame when started pinching to resize
  • Used the cached window frame instead of the current window frame to avoid accumulated rounding errors

Before:
https://github.com/iina/iina/assets/20237141/3bfc10d4-5fbc-419d-80e1-9d41ca6ea623

After:
https://github.com/iina/iina/assets/20237141/eff9cb20-38a0-43d3-a70b-63cdd1d10c6f

@uiryuu
Fix the window is shifted when pinching to resize, #4681
0bde5f9 
- Cache the window frame when started pinching to resize
- Used the cahced window frame instead of the current window frame to
  avoid accumulated rounding errors
@uiryuu uiryuu linked an issue Jun 30, 2024 that may be closed by this pull request
Pinch to Adjust video size shift the window position #4681
Closed
1 task
low-batt
low-batt approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor
@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced problem with 1.3.5. Pulled PR, built, tested, confirmed fixed. Looks good to me.

@uiryuu uiryuu merged commit f33bd5d into develop Jul 1, 2024
1 check passed
@uiryuu uiryuu deleted the fix-pinch-shifts-window branch July 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@low-batt low-batt low-batt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinch to Adjust video size shift the window position
2 participants
@uiryuu @low-batt
0