8000 New deforest() function for removing trees from a fitted random forest by bgreenwell · Pull Request #571 · imbs-hl/ranger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New deforest() function for removing trees from a fitted random forest #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

bgreenwell
Copy link
Contributor

Hi @mnwright,

This PR addresses issue (#568), and contains the following changes:

  • New file R/deforest.R containing the new `deforest() function with full documentation, examples, and relevant links.
  • New file tests/testthat/ranger_deforest.R for testing the expected output of deforest(). (Survival forests are the only tree type not currently supported.)
  • New file R/print.deforest.ranger.R containing a modified version of print.ranger() with full documentation.

Please let me know if I missed something or you notice any issues.

Best,

Brandon G.

@bgreenwell
Copy link
Contributor Author

Looks like I didn’t catch the missing documentation for one of the arguments. Will push an update shortly.

Copy link
Member
@mnwright mnwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we should also add this for survival.

The .dll file should not be in the PR.

@bgreenwell
Copy link
Contributor Author

Added support for survival forests, updated tests, and removed the .dll.

@mnwright mnwright merged commit 9aac567 into imbs-hl:master Nov 12, 2021
@mnwright
Copy link
Member

Thanks, merged (finally!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0