8000 CMake portability improvements by jschueller · Pull Request #686 · imbs-hl/ranger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CMake portability improvements #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2025
Merged

CMake portability improvements #686

merged 6 commits into from
Apr 3, 2025

Conversation

jschueller
Copy link
Contributor

No description provided.

@jschueller jschueller marked this pull request as ready for review September 1, 2023 15:06
@jschueller
Copy link
Contributor Author

@mnwright it should build now, could you restart the CI ?

@jschueller
Copy link
Contributor Author

hello @mnwright could you look at this one please ?

@mnwright
Copy link
Member
mnwright commented Oct 7, 2024

Could you explain the changes a little bit? My cmake is a little rusty.

@jschueller
Copy link
Contributor Author

yes, of course:

  • We must check if the -Wall flag is supported by the compiler, eg unsupported on msvc
  • We build ranger as a library can be used from another c++ project
  • The minimum cmake version must be incremented to 3.5 to avoid warnings (3.5 is pretty old anyways)
  • We add an install rule (to be able to do "make install") so that ranger is easier to use in package managers
  • We add a getopt function for targets where its unsupported (msvc)

@jschueller
Copy link
Contributor Author

any update @mnwright ?

@mnwright mnwright merged commit 899909c into imbs-hl:master Apr 3, 2025
8 checks passed
@mnwright
Copy link
Member
mnwright commented Apr 3, 2025

Finally 😄

@jschueller jschueller deleted the cmake branch April 3, 2025 06:20
@jschueller
Copy link
Contributor Author

thanks!

@jschueller jschueller mentioned this pull request Apr 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschueller @mnwright
0