Propagate RAView type variables to RAIView, RRAView 8000 #379
Conversation
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/99 |
|
This could work, I think. Did you / could you please check that this does not break any of the discoverability and type-safety features discussed in https://forum.image.sc/t/recent-and-upcoming-imglib2-improvements/96083?u=tpietzsch? Can you explain what wouldn't work here without #378? |
Ooh, actually, this may work as is without #378. What wouldn't work is the following, which I hadn't yet added but would make a lot of sense if we did go with #378: @@ -72,7 +70,7 @@ import net.imglib2.view.Views;
* @author Michael Innerberger
* @see Views
*/
-public interface RealRandomAccessibleView< T, V extends RealRandomAccessibleView<T, V> > extends RealRandomAccessible< T >
+public interface RealRandomAccessibleView< T, V extends RealRandomAccessibleView<T, V> > extends RandomAccessibleView<T, V>, RealRandomAccessible< T >
{
RealRandomAccessible< T > delegate();
Can you be more specific about where you're concerned? Happy to write tests to ensure proper behavior. |
This PR is built atop #378 - in many ways, these changes motivated the changes in that PR. Therefore, it should be reviewed first. It also warrants a major version bump.
Closes #377