8000 Change required gamepad index to -1 by toji · Pull Request #690 · immersive-web/webxr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change required gamepad index to -1 #690

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Change required gamepad index to -1 #690

merged 1 commit into from
Jun 11, 2019

Conversation

toji
Copy link
Member
@toji toji commented Jun 11, 2019

/fixes #583

The gamepad API specifies that the index is a long. It's only Chrome's implementation that uses an unsigned value.

@toji toji requested a review from NellWaliczek June 11, 2019 20:19
@toji toji added this to the June 2019 milestone Jun 11, 2019
@ddorwin ddorwin mentioned this pull request Jun 11, 2019
Closed
@NellWaliczek NellWaliczek merged commit f3cd523 into master Jun 11, 2019
@AdaRoseCannon AdaRoseCannon added the ed:spec Include in newsletter, spec change label Jun 17, 2019
@toji toji deleted the gamepad-index branch July 2, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NellWaliczek NellWaliczek NellWaliczek approved these changes

Assignees
No one assigned
Labels
ed:spec Include in newsletter, spec change
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.

Decide what to do with Gamepad.index
3 participants
@toji @NellWaliczek @AdaRoseCannon
0