Merge 'end the session' with 'shut down the session', clarify, add onend event #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @toji |
toji
requested changes
Jun 17, 2019
| @@ -443,8 +443,12 @@ When an {{XRSession}} is shut down the following steps are run: | |||
| 1. Set |session|'s [=ended=] value to <code>true</code>. | |||
| 1. If the [=active immersive session=] is equal to |session|, set the [=active immersive session=] to <code>null</code>. | |||
| 1. Remove |session| from the [=list of inline sessions=]. < 8000 /td> | |||
| 1. [=Reject=] any outstanding promises returned by |session| with an {{InvalidStateError}}. | |||
| 1. If no other features of the user agent are actively using them, perform the necessary platform-specific steps to shut down the device's tracking and rendering capabilities. | |||
| 1. [=Reject=] any outstanding promises returned by |session| with an {{InvalidStateError}}, except for any promises returned by {{XRSession/end()}}. | |||
index.bs
Outdated
| 1. [=Reject=] any outstanding promises returned by |session| with an {{InvalidStateError}}, except for any promises returned by {{XRSession/end()}}. | ||
| 1. If no other features of the user agent are actively using them, perform the necessary platform-specific steps to shut down the device's tracking and rendering capabilities. This MUST include: | ||
| - Releasing [=exclusive access=] to the [=/XR device=]. | ||
| - Deallocating any framebuffers attached by the |session| to the [=/XR device=]. |
There was a problem hiding this comment.
"Attached" doesn't seem like the right word here? Also it may not always be framebuffers specifically, so maybe something more like this (keeping in line with your recent swap chain PR)?
Deallocating any graphics resources acquired by the |session| for presentation to the [=/XR device=].
There was a problem hiding this comment.
That makes sense. Getting on a flight soon, will push this fix later.
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #467
Not quite sure of this, also not sure of what precisely we should list in the platform specific steps.