8000 Removes references to "immersive-ar" and XRRay by NellWaliczek · Pull Request #784 · immersive-web/webxr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes references to "immersive-ar" and XRRay #784

Merged
merged 6 commits into from
Aug 3, 2019
Merged

Removes references to "immersive-ar" and XRRay #784

merged 6 commits into from
Aug 3, 2019

Conversation

NellWaliczek
Copy link
Member
@NellWaliczek NellWaliczek commented Jul 30, 2019 •
edited
Loading

This is the second of two PRs to execute the decision to split the WebXR API into separate modules. This PR handles removing the content moving to the new WebXR Augmented Reality Module. Removed content can be found in the partner PR in the new module repo immersive-web/webxr-ar-module#1

toji
toji requested changes Jul 30, 2019
View reviewed changes
Copy link
Member
@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One nit and one required change, but otherwise I think it looks good!

@NellWaliczek NellWaliczek marked this pull request as ready for review July 31, 2019 21:12
@NellWaliczek NellWaliczek changed the title [DRAFT] Removes references to "immersive-ar" and XRRay Removes references to "immersive-ar" and XRRay Jul 31, 2019
toji
toji approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member
@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

johnpallett
johnpallett reviewed Aug 2, 2019
View reviewed changes
@NellWaliczek NellWaliczek merged commit b5ce1e4 into master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klausw klausw klausw left review comments

@johnpallett johnpallett johnpallett left review comments

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NellWaliczek @toji @klausw @johnpallett
0