api/soundcloud: add more metadata fields #1313
Merged
+26
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
couldn't find a track with a composer but i pinky promise it gets parsed properly. here's another track which also has a genre specified: |
wukko
requested changes
Jun 3, 2025
if you can't find it, then it's probably not there. i wouldn't add something you're not sure in existence of. you can always add it later! |
turns out I just didn't look hard enough, this song by Imogen Heap has proper credits {
"id": 1978104099,
"urn": "soundcloud:tracks:1978104099",
"artist": "Imogen Heap",
// ........
"writer_composer": "Imogen Heap, Guy Sigsworth",
"release_title": "Let Go (on the hang in the park)"
} |
0afa2b1 to
88e8b52
Compare
|
@wukko reminder to review again pls |
wukko
requested changes
Jun 7, 2025
88e8b52 to
845bad8
Compare
|
thought i was PRing to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this sug
2F23
gestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds and documents the
composer,genreandalbum_artistmetadata tags. it also adds more metadata parsing to the soundcloud service:albumalbum_artistcomposergenredatecopyrightwhy?
having more metadata is always nice. this is a comparison with onthespot in foobar2000
PS: invest in a formatter. please