update to EML 2.2.0 #161
Open
update to EML 2.2.0 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1204 1205 +1
=========================================
+ Hits 1204 1205 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterdesmet
requested changes
Apr 8, 2025
| @@ -76,19 +76,20 @@ write_eml <- function(x, directory, derived_paragraph = TRUE) { | |||
| eml$dataset$title <- x$title | |||
|
|
|||
| # Set abstract, with optional extra paragraph | |||
| para <- x$description | |||
| para <- x$description %>% | |||
| # Add <p></p> tags to each paragraph | |||
There was a problem hiding this comment.
You are not adding
to each paragraph here, but rather wrapping the entire description as a single paragraph.x$description can contain empty lines, so I suggest you use what you used in bird-tracking here:
paragraphs <- unlist(strsplit(description_full, "<p>|</p>|\n"))
paragraphs <- paragraphs[paragraphs != ""]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPT (v 3.1.0) updated from EML 2.1.1 to EML 2.2.0, solving ropensci/EML#342. We update our scripts accordingly.