101 new function shape to geojson #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
…m/inbo/fistools into 101-new-function-shape-to-geojson
There was a problem hiding this comment.
Pull Request Overview
A new shape_to_geojson function was added to convert shapefiles to GeoJSON, with updates to exports, dependencies, and documentation to support the feature.
- Implemented
shape_to_geojsoninR/shape_to_geojson.R - Exported the new function and added
heretoDESCRIPTION - Bumped package version to 1.2.20 and updated site docs (pkgdown version and cross-references)
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/reference/*.html | Bumped package version (1.2.19 → 1.2.20), updated pkgdown build version, added GeoJSON link in See also where relevant |
| R/shape_to_geojson.R | Added new function to convert shapefiles to GeoJSON |
| NAMESPACE | Exported shape_to_geojson |
| DESCRIPTION | Updated Version to 1.2.20 and added here to Imports |
Comments suppressed due to low confidence (2)
R/shape_to_geojson.R:1
- [nitpick] The new function lacks accompanying unit tests. Consider adding tests for directory vs single-file inputs, CRS transformations, and overwrite behavior.
#' Convert shapefiles to geojson
R/shape_to_geojson.R:2
- [nitpick] The roxygen documentation mixes Dutch and English. For consistency with the rest of the package, consider writing all documentation in English.
#' Deze functie zet alle shapes in een specifieke map, één bestand of een lijst van bestanden
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #101 by reworking shape_to_geojson.R from the backoffice