8000 Sfp 104 nl by ToonVanDaele · Pull Request #135 · inbo/protocolsource · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sfp 104 nl #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 23, 2025
Merged

Sfp 104 nl #135

merged 23 commits into from
May 23, 2025

Conversation

ToonVanDaele
Copy link
Collaborator
@ToonVanDaele ToonVanDaele commented May 23, 2025

Description

Added a safety requirement related to the presence of pipelines

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

@ToonVanDaele ToonVanDaele marked this pull request as ready for review May 23, 2025 12:39
@hansvancalster hansvancalster merged commit e63ad75 into main May 23, 2025
2 checks passed
@hansvancalster hansvancalster deleted the sfp-104-nl branch May 23, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0