Address bad karma opts #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karma v6 fails on invalid command line args. Doo was passing opts + compiled js to karma when it should have only been passing opts.
This will make it less confusing when clicking on github repo link from clojars.
|
Hi, thanks for submitting! This seems pretty simple and low risk to me, how sure are you that this won't break anything? A short description of the PR would be helpful, like:
|
I think we are good. If something unexpected comes up after release, I'll help to address. |
|
@ingesolvoll, please let me know if there is anything else you'd like me to do before you merge and deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Karma v6:
It turns out that doo has been passing bad opts to karma, but karma just used to grin and take it. No longer.
This change adds a check to see if doo has been asked to target karma, and if so, only passes config.
Doo was formerly passing config and compiled JavaScript to karma, karma does not expect compiled JavaScript.
Change tested with Karma v5 and v6 in rewrite-clj which uses cljs-test-runner (and hence this fork of doo) to target node, chrome-headless (via karma) and planck.
I tried running unit test for doo via
lein testbut it appears they are in a broken state?