Remove our own custom FQCN visitor as we already use php-parser's NameResolver visitor
#1123
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
mt-annotations.yaml
on: pull_request
Matrix: tests
Annotations Status
0s
Annotations
3 warnings
|
Mutation Testing Code Review Annotations 8.1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Mutation Testing Code Review Annotations 8.1:
src/PhpParser/Visitor/FullyQualifiedClassNameManipulator.php#L50
Escaped Mutant for Mutator "Coalesce":
--- Original
+++ New
@@ @@
use CannotBeInstantiated;
public static function getFqcn(Node $node): ?Node\Name
{
- return $node->namespacedName ?? $node->getAttribute('resolvedName') ?? $node->getAttribute('namespacedName');
+ return $node->getAttribute('resolvedName') ?? $node->namespacedName ?? $node->getAttribute('namespacedName');
}
}
|
|
Mutation Testing Code Review Annotations 8.1:
src/PhpParser/Visitor/FullyQualifiedClassNameManipulator.php#L51
Escaped Mutant for Mutator "Coalesce":
--- Original
+++ New
@@ @@
use CannotBeInstantiated;
public static function getFqcn(Node $node): ?Node\Name
{
- return $node->namespacedName ?? $node->getAttribute('resolvedName') ?? $node->getAttribute('namespacedName');
+ return $node->namespacedName ?? $node->getAttribute('namespacedName') ?? $node->getAttribute('resolvedName');
}
}
|