8000 Do not mutate `$var instanceof ClassName` inside `assert()` function as it's impossible or hard to kill by maks-rafalko · Pull Request #1852 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not mutate $var instanceof ClassName inside assert() function as it's impossible or hard to kill #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

Do not mutate $var instanceof ClassName inside assert() function as it's impossible or hard to kill #1852

merged 1 commit into from
May 11, 2023

Conversation

maks-rafalko
Copy link
Member

Fixes #1845

@maks-rafalko maks-rafalko marked this pull request as ready for review May 11, 2023 20:10
@maks-rafalko maks-rafalko merged commit 2b24408 into master May 11, 2023
@maks-rafalko maks-rafalko deleted the feature/1845-assert-instance-of branch May 11, 2023 21:02
@maks-rafalko
Copy link
Member Author

Thank you @sidz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidz sidz sidz approved these changes

Assignees
No one assigned
Labels
Mutator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not mutate instanceof in assert()
2 participants
@maks-rafalko @sidz
0