Fix usage of custom mutator with bootstrap file #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Infection Playground, we don't use composer to load files in PSR-4 format, we use custom very simple PSR-4 compliant autoloader, which is configured to be used in `infection.json5` in `bootstrap` setting. In `master` branch, Infection tries to `resolveMutators()` **before** loading bootstrap files, thus failing finding custom mutator. In order to prepare configuration, where custom mutators are resolved, we need to load (`require_once`) custom bootstrap file before mutators are resolved. This fixes the bug and allows Playground to use custom mutators.
maks-rafalko
commented
Jun 1, 2024
| null, | ||
| null, | ||
| null, | ||
| ['@default' => false, 'CustomMutator' => true], |
There was a problem hiding this comment.
here is a trick: we use CustomMutator alias, that is only available if bootstrap file is executed, making this alias available for class autoloader.
This confirms that custom mutator works with bootstrap
github-merge-queue bot
referenced
this pull request
in Lendable/json-serializer
Jun 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [infection/infection](https://togithub.com/infection/infection) | `^0.29.0` -> `^0.29.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>infection/infection (infection/infection)</summary> ### [`v0.29.1`](https://togithub.com/infection/infection/releases/tag/0.29.1): Fix usage of custom mutator with bootstrap file [Compare Source](https://togithub.com/infection/infection/compare/0.29.0...0.29.1) **Fixed:** - Fix usage of custom mutator with bootstrap file by [@​maks-rafalko](https://togithub.com/maks-rafalko) in [https://github.com/infection/infection/pull/1973](https://togithub.com/infection/infection/pull/1973) **Full Changelog**: infection/infection@0.29.0...0.29.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/json-serializer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Infection Playground, for each "playground run" we don't use composer to load files in PSR-4 format, we use custom very simple PSR-4 compliant autoloader, which is configured to be used in
infection.json5inbootstrapsetting.In
masterbranch, Infection tries toresolveMutators()before loading bootstrap files, thus failing finding custom mutator.In order to prepare configuration, where custom mutators are resolved, we need to load (
require_once) custom bootstrap file before mutators are resolved.This fixes the bug and allows Playground to use custom mutators right in the browser.