8000 Attempt to switch to `shish/safe` to fix issue with `thecodingmachine/safe` by sanmai · Pull Request #2017 · infection/infection · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Attempt to switch to shish/safe to fix issue with thecodingmachine/safe #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 17, 2024
Merged

Attempt to switch to shish/safe to fix issue with thecodingmachine/safe #2017

merged 6 commits into from
Dec 17, 2024

Conversation

sanmai
Copy link
Member
@sanmai sanmai commented Dec 9, 2024 •
edited by maks-rafalko
Loading

Should fix #2015

sanmai
sanmai commented Dec 9, 2024
View reviewed changes
maks-rafalko
maks-rafalko reviewed Dec 9, 2024
View reviewed changes
maks-rafalko added a commit that referenced this pull request Dec 14, 2024
@maks-rafalko
Bump PHP version to 8.2
334f512 
Extracted from #2017

See

- https://github.com/infection/infection/blob/master/adr/0005-Bump-PHP-versions.md
- https://www.php.net/supported-versions.php
@maks-rafalko maks-rafalko mentioned this pull request Dec 14, 2024
Merged
maks-rafalko added a commit that referenced this pull request Dec 14, 2024
@maks-rafalko
Bump PHP version to 8.2 (#2018)
0d238ba 
Extracted from #2017

See

- https://github.com/infection/infection/blob/master/adr/0005-Bump-PHP-versions.md
- https://www.php.net/supported-versions.php
maks-rafalko added a commit that referenced this pull request Dec 14, 2024
@maks-rafalko
Upgrade rector set to PHP 8.2 (#2019)
af019e6 
* Bump PHP version to 8.2

Extracted from #2017

See

- https://github.com/infection/infection/blob/master/adr/0005-Bump-PHP-versions.md
- https://www.php.net/supported-versions.php

* Upgrade rector set to PHP 8.2
@maks-rafalko
Copy link
Member

one more merge is needed after #2020 please

@maks-rafalko maks-rafalko marked this pull request as ready for review December 17, 2024 18:15
@maks-rafalko maks-rafalko enabled auto-merge (squash) December 17, 2024 18:16
@maks-rafalko
Copy link
Member

thecodingmachine/phpstan-safe-rule is not compatible with shish/safe so I had to remove it and add a couple of errors to phpstan-baseline files.

Hopefully, all of this will be reverted once/if thecodingmachine/safe is released.

@maks-rafalko
Copy link
Member

Let's try..

@maks-rafalko maks-rafalko merged commit cac7d20 into infection:master Dec 17, 2024
61 checks passed
@darthf1
Copy link
Contributor
darthf1 commented Dec 17, 2024 •
edited
Loading

thecodingmachine/phpstan-safe-rule is not compatible with shish/safe so I had to remove it and add a couple of errors to phpstan-baseline files.

Hopefully, all of this will be reverted once/if thecodingmachine/safe is released.

If preferred to keep the phpstan rule, you could have a look at https://github.com/shish/phpstan-safe-rule

@maks-rafalko
Copy link
Member

oh, thanks for highlighting, didn't see it.

I hope we will soon just revert this PR. If not, I will introduce shish/phpstan-safe-rule to Infection, but for now I hope it's not needed (I can be wrong)

@maks-rafalko maks-rafalko changed the title Attempt to switch to shish/safe Attempt to switch to shish/safe to fix issue with thecodingmachine/safe Dec 18, 2024
@smoench smoench mentioned this pull request Dec 18, 2024
Closed
@sanmai sanmai deleted the shish/safe branch December 18, 2024 12:14
@darthf1
Copy link
Contributor
darthf1 commented Feb 11, 2025

oh, thanks for highlighting, didn't see it.

I hope we will soon just revert this PR. If not, I will introduce shish/phpstan-safe-rule to Infection, but for now I hope it's not needed (I can be wrong)

You can now :)

https://github.com/thecodingmachine/safe/releases/tag/v3.0.0 https://github.com/thecodingmachine/phpstan-safe-rule/releases/tag/v1.4.0

@maks-rafalko maks-rafalko mentioned this pull request Feb 13, 2025
Closed
@maks-rafalko
Copy link
Member

Thanks. For now, blocked with theofidry/makefile#59

I will make a revert once we unblocked.

@theofidry
Copy link
Member

@maks-rafalko I'll do a release tonight

@theofidry
Copy link
Member

done

@maks-rafalko maks-rafalko mentioned this pull request Feb 17, 2025
Closed
maks-rafalko added a commit that referenced this pull request Feb 17, 2025
@maks-rafalko
Revert "Attempt to switch to shish/safe (#2017)"
a7ecb85 
This reverts commit cac7d20.
@maks-rafalko
Copy link
Member

thanks

opened PR: #2037

maks-rafalko added a commit that referenced this pull request Feb 17, 2025
@maks-rafalko
Feature/safe revert back (#2037)
dfe9cf6 
* Revert "Attempt to switch to shish/safe (#2017)"

This reverts commit cac7d20.

* Replace `shish/safe` with `thecodingmachine/safe` v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency "thecodingmachine/safe" outdated generate Deprecated logs
4 participants
@sanmai @maks-rafalko @darthf1 @theofidry
0