8000 Secondary index support string by wuxiaobai24 · Pull Request #1307 · infiniflow/infinity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Secondary index support string #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Alre 8000 ady on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2024
Merged

Secondary index support string #1307

merged 3 commits into from
Jun 9, 2024

Conversation

wuxiaobai24
Copy link
Contributor
@wuxiaobai24 wuxiaobai24 commented Jun 8, 2024 •
edited by yingfeng
Loading

What problem does this PR solve?

Secondary index support string type by hashing.

Issue link:#1235

Type of change

  • New Feature (non-breaking change which adds functionality)

@yingfeng
Copy link
Member
yingfeng commented Jun 8, 2024

Thanks for your contribution!
Could you please add slt tests to this pr? An example for secondary index could be seen here:
https://github.com/infiniflow/infinity/blob/main/test/sql/dql/index_scan/index_scan_date.slt

@wuxiaobai24
Copy link
Contributor Author

Thanks for your contribution! Could you please add slt tests to this pr? An example for secondary index could be seen here: https://github.com/infiniflow/infinity/blob/main/test/sql/dql/index_scan/index_scan_date.slt

ok, I've added slt test:
https://github.com/infiniflow/infinity/pull/1307/files#diff-f09a01a23fac82f5ff2da1689eadbdacb789fc3843874baae225a09dfd8df708

@yingfeng yingfeng added ci PR can be test and removed ci PR can be test labels Jun 8, 2024
@yingfeng
Copy link
Member
yingfeng commented Jun 8, 2024

Your working branch is not clean, you could keep it consistent with upstream and submit pr again.

@wuxiaobai24
Copy link
Contributor Author

Your working branch is not clean, you could keep it consistent with upstream and submit pr again.

ok, It looks like I'm using a wrong way to merge the upstream code.
8000

@wuxiaobai24 wuxiaobai24 force-pushed the secondary-index-support-string branch from 47a8fcf to 8e79fcf Compare June 9, 2024 03:09
@yingfeng yingfeng added the ci PR can be test label Jun 9, 2024
@yingfeng yingfeng requested a review from yangzq50 June 9, 2024 04:47
yangzq50
yangzq50 approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor
@yangzq50 yangzq50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@yingfeng yingfeng merged commit 6bb03cd into infiniflow:main Jun 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5E10
Reviewers

@yangzq50 yangzq50 yangzq50 approved these changes

Assignees
No one assigned
Labels
ci PR can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuxiaobai24 @yingfeng @yangzq50
0