-
Notifications
You must be signed in to change notification settings - Fork 515
[Merged by Bors] - Fix some typo Event change_listener #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
crates/fluvio-stream-dispatcher/src/dispatcher/k8_ws_service.rs
Outdated
Show resolved
Hide resolved
7a4885c
to
fd899c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a patch bump in fluvio
and fluvio-types
crates. Once that is done, I think that this is ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Lets add to changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment 8000 to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`: * deprecate `change_listner` * replace by `change_listener` Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Build failed: |
bors r+ |
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`: * deprecate `change_listner` * replace by `change_listener` Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Build failed: |
bors retry |
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`: * deprecate `change_listner` * replace by `change_listener` Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Build failed: |
bors r+ |
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`: * deprecate `change_listner` * replace by `change_listener` Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Fix typo in
fluvio_types::event::offsets::OffsetPublisher
:change_listner
change_listener