8000 fix(select-rich): readonly works with keyboard interaction by wessamzaghloul · Pull Request #2235 · ing-bank/lion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(select-rich): readonly works with keyboard interaction #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2024
8000
Merged

fix(select-rich): readonly works with keyboard interaction #2235

merged 1 commit into from
Apr 3, 2024

Conversation

wessamzaghloul
Copy link
Contributor

What I did

  1. fixes #2208

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 673a0d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
CLAassistant commented Mar 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ryubro ryubro mentioned this pull request Mar 31, 2024
Merged
gerjanvangeest
gerjanvangeest reviewed Apr 2, 2024
View reviewed changes
Copy link
Member
@gerjanvangeest gerjanvangeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset (npm run changeset), so the change will trigger the release PR and will end up in our changelog?

@wessamzaghloul wessamzaghloul force-pushed the fix/select-rich-readonly-keyboard-interaction branch from 1a02851 to a828ee3 Compare April 2, 2024 16:28
@wessamzaghloul wessamzaghloul force-pushed the fix/select-rich-readonly-keyboard-interaction branch from a828ee3 to 673a0d7 Compare April 2, 2024 16:55
gerjanvangeest
gerjanvangeest approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member
@gerjanvangeest gerjanvangeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wessamzaghloul thanks for the fix!

@gerjanvangeest gerjanvangeest merged commit d2edadd into ing-bank:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryubro ryubro ryubro left review comments

@gerjanvangeest gerjanvangeest gerjanvangeest approved these changes

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select-rich when [read-only] it still works with keyboard interaction
4 participants
@wessamzaghloul @CLAassistant @ryubro @gerjanvangeest
0