8000 Revert "feat: migrated the navigation metadata from inline MD title d… by ryubro · Pull Request #2499 · ing-bank/lion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "feat: migrated the navigation metadata from inline MD title d… #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "feat: migrated the navigation metadata from inline MD title d… #2499

wants to merge 1 commit into from

Conversation

ryubro
Copy link
Contributor
@ryubro ryubro commented Mar 24, 2025

…ecorations to frontmatter "

This reverts commit 11bbc5f.

What I did

We reuse the document of Lion in another product, and this change breaks that part.

I can imagine a few approaches:

  • preprocess the lion document before reusing it in the other product
  • programatically process the rocket-compatible documents into Astro compatible document before feeding it to the Astro engine

None of above is done yet, we should revert the change at the moment.

@ryubro
Revert "feat: migrated the navigation metadata from inline MD title d…
803ae59 
…ecorations to frontmatter "

This reverts commit 11bbc5f.
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 803ae59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tlouisse tlouisse mentioned this pull request Mar 26, 2025
Merged
@tlouisse
Copy link
Member
tlouisse commented Mar 26, 2025 •
edited
Loading

See #2500 for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okadurin okadurin okadurin approved these changes

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest is a code owner

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryubro @tlouisse @okadurin
0