feat(input-stepper): add alignToStep property to align value with ste… #2511
+146
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 233db85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
| const newValue = this.currentValue + step; | ||
| let newValue = this.currentValue + step; | ||
|
|
||
| if (this.alignToStep && (this.currentValue + min) % step !== 0) { |
There was a problem hiding this comment.
Yes, it makes better sense to me but we're introducing a break change. Maybe we should offer an option that is opposite to alignToStep, for those possible consumers who are using the current behavior as a feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding property alingToStep on input-stepper.
When property enabled, clicking on + or - button will verify the next step to reach and align on step multiple if user did enter custom value in between.
example
min 0
max 100
step 10
current value 55
click + ==> 60 instead of 65
click - ==> 50 instead of 55
if min is not 0:
min 3
max 100
step 10
current value 55
click + ==> 63 instead of 65
click - ==> 53 instead of 55
What I did
I made multiple try with the changeset but I don't find how to do it correctly.