Add file import/export #1
Conversation
|
Do you want to make the first draft or need some input? |
|
I will make a first draft. |
|
After some investigation i'm not sure how to link our modules. My module just create an ir.attachment from a remote file or a file from an ir.attachment. So do you think we should separate the transfert task from the flow and start the flow from a ir.attachment? |
|
the first task in a flow is to download it and store it in ir.attachment and the the next steps runs |
|
There is already the same logic, i have an abstract task with a run method. What do you think about that? Maybe we can ask @guewen or @sebastienbeau for their opinion to have the better solution. |
|
i need to discuss this with @codingforfun for this details
|
|
I had a deeper look into your code. My impression is that our approaches are at some points very similar but focussed on somewhat different problems we try to solve. If I've understood your approach correctly, it seams to me you are mainly implementing some very cool approach for automatic file syncing for Odoo like a dropbox folder on a local machine. Our focus is on automated processing of information by a chain of various processing step. Import/Export is just a single aspect of this. One of our main goals is to make every step robust, traceable and repeatable in case of error. That is why we build on top of the connector. It's right that FTP is just one special kind of task in our framework, so it would make sense to refactor this to split up into a core framework and helper tasks, but since your approach brings it's own kind of task framework I'm not sure what could be a good way to unite with our approach. I think it's not possible to just plug both approaches together. Maybe we could reuse some of the ideas. I think the meta data approach for |
|
Thanks for the comment, i will discuss with my coworker about your suggestion and I will tell what we can do about it. |
|
Hi, I think too, that our both module do not solve the same problem. Plugin both is maybe not an easy task but I think it's worth
Regarding the dependency of connector or not I would like to have the opinion of @guewen Regarding the French carrier, the export is a simple csv EDI file that reprensent a batch of picking and the import is an SQL request that update a huge table of records. @Viggor will try to propose a POC of how we can connect both system, so we can start thinking of the impact of merging both project. What do you think? |
|
I've make a first POC for our modules integration. It works with well with your ftp export example module. |
|
Ok. Interesting. Thanks. I will try to have a deeper look as soon as possible and discuss with @OSguard |
|
|
||
| def _get_method(self): | ||
| res = [] | ||
| for cls in itersubclasses(AbstractTask): |
There was a problem hiding this comment.
It will load classes of uninstalled addon as well. In connector we also check if the addons from where the class comes is installed or not.
There was a problem hiding this comment.
Now these class are push away of the code evaluation. Thanks to point it.
|
a short update, we hope to provide a feedback from our site next week (sorry this was delayed two weeks). Hope we can make it befor the holidays |
|
Ok no problem thanks! |
Module to handle file transfert