8000 feat: add hashed address check to hook receiver validation by sh-cha · Pull Request #399 · initia-labs/initia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add hashed address check to hook receiver validation #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

feat: add hashed address check to hook receiver validation #399

merged 3 commits into from
May 8, 2025

Conversation

sh-cha
Copy link
Contributor
@sh-cha sh-cha commented May 8, 2025 •
edited by beer-1
Loading

close #396

allow to execute hook receiver as both receiver == functionIdentifier and receiver == bech32("init", sha256(functionIdentifier))

        functionIdentifier := fmt.Sprintf("%s::%s::%s", msg.ModuleAddress, msg.ModuleName, msg.FunctionName)
 	if receiver == functionIdentifier {
 		return nil
 	}

 	hashedFunctionIdentifier := sha256.Sum256([]byte(functionIdentifier))
 	hashedFunctionIdentifierString, err := ac.BytesToString(hashedFunctionIdentifier[:])

@sh-cha sh-cha self-assigned this May 8, 2025
@sh-cha sh-cha requested a review from a team as a code owner May 8, 2025 05:07
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 8, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A new test was added to verify ICS20 packet handling when the receiver uses a hashed Cosmos SDK address. The validateReceiver function was updated to accept both Move VM address strings and their hashed forms. Corresponding unit tests were introduced to ensure correct validation of both receiver formats. Calls to validateReceiver were updated to include an account codec parameter.

Changes

File(s) Change Summary
x/ibc-hooks/move-hooks/receive_test.go Added Test_onReceiveIcs20Packet_memo_with_hashed_receiver to test ICS20 packet handling with hashed receiver addresses.
x/ibc-hooks/move-hooks/util.go Modified validateReceiver signature to include codec; updated logic to accept both Move VM address strings and SHA-256 hashed addresses.
x/ibc-hooks/move-hooks/util_test.go Added Test_validateReceiver to verify validateReceiver accepts both string and hashed receiver formats; updated existing tests to pass codec argument.
x/ibc-hooks/move-hooks/receive.go Updated calls to validateReceiver to pass the ac codec parameter in onRecvIcs20Packet and onRecvIcs721Packet.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Suite
    participant Handler as ICS20 Packet Handler
    participant Validator as validateReceiver
    participant Contract as Move Contract

    Test->>Handler: Send ICS20 packet with hashed receiver
    Handler->>Validator: validateReceiver(msg, receiver, ac)
    Validator-->>Handler: Return error (if ACL not set)
    Test->>Handler: Set ACL, resend packet
    Handler->>Validator: validateReceiver(msg, receiver, ac)
    Validator-->>Handler: Success
    Handler->>Contract: Execute Move function
    Contract-->>Handler: State updated
    Handler-->>Test: Confirm contract state incremented
Loading

Poem

In the warren of code, a new path appears,
Where hashed and stringed receivers calm our fears.
Packets hop safely, both forms now allowed,
With tests to ensure the logic stands proud.
The rabbits rejoice as validation grows—
Address or hash, the contract still knows! 🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between 9b315da and e871f9e.

📒 Files selected for processing (1)
  • x/ibc-hooks/move-hooks/util.go (3 hunks)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 8, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov Codecov
Copy link
codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.18%. Comparing base (8f1271e) to head (a54b86c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   40.18%   40.18%           
=======================================
  Files         294      294           
  Lines       27542    27543    +1     
=======================================
+ Hits        11067    11068    +1     
  Misses      14772    14772           
  Partials     1703     1703
Files with missing lines Coverage Δ
x/ibc-hooks/move-hooks/util.go 84.93% <100.00%> (+0.20%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beer-1 beer-1 enabled auto-merge (squash) May 8, 2025 05:28
beer-1
beer-1 approved these changes May 8, 2025
View reviewed changes
Copy link
Member
@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit c0415b0 into main May 8, 2025
4 of 6 checks passed
@beer-1 beer-1 deleted the feat/ibc-hook-receiver-validation branch May 8, 2025 05:30
@beer-1 beer-1 changed the title add hashed address check to hook receiver validation feat: add hashed address check to hook receiver validation May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

Assignees

@sh-cha sh-cha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: allow to put only contract address as receiver
2 participants
@sh-cha @beer-1
0