-
Notifications
You must be signed in to change notification settings - Fork 8
Maintain/implementation details #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @siddarthsingh1 :) Just a few comments:
- Did you pull in the changes from main before making this? The structure has changed and we no longer have subfolders for each topic, since that becomes more tricky to maintain and you have to capture each paper twice then. Please have a look at the main branch to see.
- Can we restrict the scope of the repo to just MAS/MARL? I.e. we won't be listing single agent papers, even if they are somewhat relevant to some of the papers we do list. I just think, if we start doing this, then the scope creep will get out of control.
merge: update formatting to match main
Hi @arnupretorius. My local repo was out of date, it's been updated now. The single agent paper has been removed, it will be much simpler to maintain only MARL papers 👍 . |
Thanks :) It seems you still need to sign the CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still seem to have a subfolder for implementation papers? Can you please remove this and only add papers to the readme under the DL section? Please also add the summaries there directly. Again, this is so that we don't have to add/capture papers twice and make creating subcategories faster and easier.
Added summaries for RETHINKING THE IMPLEMENTATION TRICKS AND MONTONICITY CONSTRAINT IN COOPERATIVE MULTI-AGENT REINFORCEMENT LEARNING , Implementation matters for deep policy gradients and The Surprising Effectiveness of PPO in Cooperative Multi-Agent Games.