8000 test: consistent naming in Cleaner, Maze, Game2048, and Minesweeper by dluo96 · Pull Request #112 · instadeepai/jumanji · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: consistent naming in Cleaner, Maze, Game2048, and Minesweeper #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2023
Merged

test: consistent naming in Cleaner, Maze, Game2048, and Minesweeper #112

merged 5 commits into from
Mar 30, 2023

Conversation

dluo96
Copy link
Contributor
@dluo96 dluo96 commented Mar 30, 2023

Closes #111.

@dluo96 dluo96 requested a review from clement-bonnet March 30, 2023 09:51
@dluo96 dluo96 self-assigned this Mar 30, 2023
@dluo96 dluo96 changed the title test: consistent naming in Cleaner, Maze, and Game2048 test: consistent naming in Cleaner, Maze, Game2048, and Minesweeper Mar 30, 2023
@dluo96 dluo96 mentioned this pull request Mar 30, 2023
Closed
clement-bonnet
clement-bonnet approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator
@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for improving consistency!

@dluo96 dluo96 enabled auto-merge (squash) March 30, 2023 10:47
@dluo96 dluo96 merged commit 8b394e2 into main Mar 30, 2023
@dluo96 dluo96 deleted the tests-consistent-naming branch March 30, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clement-bonnet clement-bonnet clement-bonnet approved these changes

Assignees

@dluo96 dluo96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: consistent naming of unit tests in Cleaner, Maze, Game2048, and Minesweeper
2 participants
@dluo96 @clement-bonnet
0