feat(connector): random walk board generator #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
5a8f4ef to
a81171b
Compare
61a26ce to
a12b23c
Compare
fb15e20 to
36ab997
Compare
af8a0a7 to
d54ab1c
Compare
clement-bonnet
requested changes
May 6, 2023
There was a problem hiding this comment.
Thank you for your contribution. I am looking forward to testing this new generator that guarantees solvability. There are lots of uses of scan when the computation has nothing inherently sequential. I believe replacing them with vmap will make the generator much faster. Please let me know if you have any questions.
|
FYI, we just merge #119 which makes Connector a single-agent environment (aggregates rewards and also simplifies the observation). Though this should not change this PR I think. |
0ba4336 to
7999007
Compare
feat: updating tests and improving generation_methods bugfix: adjusting tests following vmap updates feat: refactoring generation methods into generator - refactoring generation methods into one generator class and updating codebase to pass linting tests feat: updating typing in Agent dataclass docs: updating docstrings in generatory.py bugfix: add extra line for black bugfix: removing unused import Empty commit
6511ecd to
3549547
Compare
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Returning agent in generate_board function Adding square assumption to grid
Adding first move at initalisation to ensure all wires have at least length 2
sash-a
reviewed
May 24, 2023
clement-bonnet
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating placeholder board generator, board class and updating tests